[pull] master from ruby:master#1028
Merged
Merged
Conversation
fafb558 fixed issues with refinement zsuper methods by converting them to a cfunc that calls super. This changes Method creation to recognize the cfunc used and skip those methods just as regular zsuper methods are skipped. This makes refinement zsuper function the same way as subclass zsuper in regards to Method/UnboundMethod.
SIZED_REALLOC_N already assigns to its first argument, and the double
assignment causes two writes to the same struct without a sequence
point, which is undefined behavior.
gc.c: In function 'rb_gc_register_address':
gc.c:3758:36: warning: operation on 'vm->global_object_list' may be undefined [-Wsequence-point]
When a single #[test] function holds multiple assert_snapshot! calls, only the first one is updated per cargo-insta run, so updating all of them takes multiple zjit-test -> zjit-test-update cycles. Splitting into one snapshot per test lets a single cycle update them all.
…17012) According to `rb_reg_nth_match`, `rb_reg_match_pre(post/last)`, `GetSpecialSymbol` and `GetSpecialNumber` always returns `StringExact` or `NilClass`. Fix `infer_type` to `StringExact|NilClass` instead of `BasicObject`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )