No error on querry missing parameter. Is it by design?

[J-Siu]

I moved a small project from sqlite3 driver to tursogo and encounter a strange error which I cannot reproduce anymore. However, I observed the following:

package main

import (
	"database/sql"
	"fmt"

	_ "turso.tech/database/tursogo"
)

func main() {
	var (
		db, err = sql.Open("turso", "test.db")
		rows    *sql.Rows
		v       int
	)
	if err == nil {
		_, err = db.Exec("CREATE TABLE IF NOT EXISTS pair (k INTEGER NOT NULL,v INTEGER NOT NULL,UNIQUE(k,v))")
	}
	if err == nil {
		_, err = db.Exec("INSERT OR IGNORE INTO pair(k,v) VALUES(1,2)")
	}
	if err == nil {
		// rows, err = db.Query("SELECT v FROM pair WHERE k=?", 1) // Correct
		rows, err = db.Query("SELECT v FROM pair WHERE k=?") // missing parameter, but no error
	}
	if err == nil {
		for rows.Next() {
			err = rows.Scan(&v)
			if err == nil {
				fmt.Println(v)
			} else {
				break
			}
		}
	}
	if rows != nil {
		rows.Close()
	}
	if err != nil {
		fmt.Println(err.Error())
	}
}

Ln24 rows, err = db.Query("SELECT v FROM pair WHERE k=?"), missing parameter for k, returns no error.

Is that by design?

[apoorva-01]

Not really by design, more like two gaps lining up.

db.Query() takes tursogo's fast path (the conn implements QueryerContext), so database/sql never runs the arg-count check it'd normally do when it prepares the statement for you. Then tursogo's own bind step only validates the count when you pass at least one arg. Zero args skips that check, the ? stays unbound, and an unbound parameter is NULL in SQLite. So your query is really WHERE k = NULL, which matches nothing (NULL never equals anything). No error, no rows.

Prepare it yourself and the mismatch does surface:

stmt, _ := db.Prepare("SELECT v FROM pair WHERE k=?")
rows, err := stmt.Query() // -> sql: expected 1 arguments, got 0

that path goes through NumInput(), which reports 1 placeholder, so database/sql rejects it before anything runs.

I'd file the direct-Query behavior as a bug though. silently dropping a WHERE because a param went missing is a rough way to find out.

[J-Siu]

Thx. I will create a bug report tonight.