Skip to content
This repository was archived by the owner on May 23, 2025. It is now read-only.

upgrade dependencies, fix some warnings#1747

Merged
connyduck merged 2 commits intodevelopfrom
upgrade_deps_fix_warnings
Apr 6, 2020
Merged

upgrade dependencies, fix some warnings#1747
connyduck merged 2 commits intodevelopfrom
upgrade_deps_fix_warnings

Conversation

@connyduck
Copy link
Copy Markdown
Collaborator

No description provided.

val positiveButton = dialog.getButton(Dialog.BUTTON_POSITIVE)
editText.onTextChanged { s, _, _, _ ->
positiveButton.isEnabled = !s.isNullOrBlank()
positiveButton.isEnabled = !s.isBlank()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it be null?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

implementation "com.squareup.okhttp3:logging-interceptor:$okhttpVersion"

implementation "org.conscrypt:conscrypt-android:2.2.1"
implementation "org.conscrypt:conscrypt-android:2.4.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not easy to dig up their changelog 🙄

@connyduck connyduck merged commit c80fa68 into develop Apr 6, 2020
@connyduck connyduck deleted the upgrade_deps_fix_warnings branch April 6, 2020 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants