implement support for HTTP proxy#489
Conversation
|
Fixes #130 |
|
This is a really cool feature, thanks for your pull requests! Some small things before I merge it: I think it would be better to put the proxy settings in their own fragment like notification and timeline filtering settings. In the main settings fragment a summary would be displayed. |
|
@connyduck I'm OK with the changes you propose, but I think I'm going to preserve the checkbox, as it allows you to temporarily disable the proxy without removing the server/port configuration. Do you like this approach? |
|
Well disabling the inputs won't delete the content, but it is just an idea, please do as you like :) |
This change allows the user to manually enter an unauthenticated proxy configuration to be used for all API connections. This is mainly intended for using Tusky with Tor (via Orbot or a local proxy).
|
@connyduck I've just put the preferences on a separate fragment, with a summary in the preference box. Please let me know if you think something else can be improved. Thanks :) |
|
It works, code looks good, super awesome, thank you! |
This change allows the user to manually enter an unauthenticated proxy
configuration to be used for all API connections. This is mainly
intended for using Tusky with Tor (via Orbot or a local proxy).