Skip to content
This repository was archived by the owner on May 23, 2025. It is now read-only.

implement support for HTTP proxy#489

Merged
connyduck merged 1 commit intotuskyapp:masterfrom
slp:http_proxy
Dec 26, 2017
Merged

implement support for HTTP proxy#489
connyduck merged 1 commit intotuskyapp:masterfrom
slp:http_proxy

Conversation

@slp
Copy link
Copy Markdown
Contributor

@slp slp commented Dec 18, 2017

This change allows the user to manually enter an unauthenticated proxy
configuration to be used for all API connections. This is mainly
intended for using Tusky with Tor (via Orbot or a local proxy).

@slp
Copy link
Copy Markdown
Contributor Author

slp commented Dec 18, 2017

Fixes #130

@connyduck
Copy link
Copy Markdown
Collaborator

This is a really cool feature, thanks for your pull requests!

Some small things before I merge it: I think it would be better to put the proxy settings in their own fragment like notification and timeline filtering settings. In the main settings fragment a summary would be displayed.
Proxy server and proxy port settings should be disabled when the checkbox is not checked (you can do this with android:dependency in xml) OR remove the checkbox and only use the proxy when server&port are filled in.
What do you think?

@slp
Copy link
Copy Markdown
Contributor Author

slp commented Dec 21, 2017

@connyduck I'm OK with the changes you propose, but I think I'm going to preserve the checkbox, as it allows you to temporarily disable the proxy without removing the server/port configuration. Do you like this approach?

@connyduck
Copy link
Copy Markdown
Collaborator

Well disabling the inputs won't delete the content, but it is just an idea, please do as you like :)

This change allows the user to manually enter an unauthenticated proxy
configuration to be used for all API connections. This is mainly
intended for using Tusky with Tor (via Orbot or a local proxy).
@slp
Copy link
Copy Markdown
Contributor Author

slp commented Dec 26, 2017

@connyduck I've just put the preferences on a separate fragment, with a summary in the preference box. Please let me know if you think something else can be improved. Thanks :)

@connyduck
Copy link
Copy Markdown
Collaborator

It works, code looks good, super awesome, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants