sam do: do not skip secret params when display node help #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe add a color or a symbol to indicate that the parameter is secret or disabled. |
added 3 commits
August 10, 2015 11:25
Only one 'print' section, for all parameters of any type.
* Clint v0.3.2 is the default version of ubuntu 14.04 * Fix tuttleofx#457
Member
Author
|
What do you think @fabiencastan of displaying parameters which are not secret in bold when get help of a node? |
And if the feature is available with clint (version >= 0.3.3).
cchampet
added a commit
that referenced
this pull request
Aug 11, 2015
sam do: * do not skip secret params when display node help * display parameters which are enabled + not secret in bold when get help of a node * fix compatibility with clint v0.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #462