Skip to content

Xử lý trường hợp thỉnh thoảng mất system tray icon #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuyenvm merged 1 commit into from
Apr 2, 2025
Merged

Xử lý trường hợp thỉnh thoảng mất system tray icon #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Sources/OpenKey/win32/OpenKey/OpenKey/SystemTrayHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ map<UINT, LPCTSTR> menuData = {
};

LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) {
static UINT taskbarCreated;

switch (message) {
case WM_CREATE:
taskbarCreated = RegisterWindowMessage(_T("TaskbarCreated"));
break;
case WM_USER+2019:
AppDelegate::getInstance()->onControlPanel();
break;
Expand Down Expand Up @@ -159,6 +164,10 @@ LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
}
break;
default:
// if the taskbar is restarted, add the system tray icon again
if (message == taskbarCreated) {
Shell_NotifyIcon(NIM_ADD, &nid);
}
return DefWindowProc(hWnd, message, wParam, lParam);
}
return 0;
Expand Down Expand Up @@ -331,7 +340,15 @@ void SystemTrayHelper::_createSystemTrayIcon(const HINSTANCE& hIns) {
loadTrayIcon();
LoadString(ins, IDS_APP_TITLE, nid.szTip, 128);
nid.uFlags = NIF_MESSAGE | NIF_ICON | NIF_TIP;
Shell_NotifyIcon(NIM_ADD, &nid);

// Shell_NotifyIcon may fail if the system tray icon is not fully initialized
const int maxRetries = 5;
for (int attempt = 0; attempt < maxRetries; ++attempt) {
if (Shell_NotifyIcon(NIM_ADD, &nid)) {
break;
}
Sleep(1000);
}
}


Expand Down