Respect custom Cargo target directories - #1235
Merged
Merged
Conversation
Owner
|
@Bortlesboat thank you for the PR. I added one small follow-up so The post-merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CARGO_TARGET_DIRwhen it is setsrc-tauri/targetlookup unchanged when the env var is absentdist/cli.jsfrom the TypeScript source changeRefs #1230
Testing
pnpm exec vitest run tests/unit/base-builder.test.tsfailed on the newCARGO_TARGET_DIRWindows artifact path assertion before the fixpnpm exec vitest run tests/unit/base-builder.test.tspnpm exec vitest runpnpm run cli:buildpnpm exec prettier --check bin/builders/BaseBuilder.ts bin/builders/LinuxBuilder.ts bin/builders/MacBuilder.ts bin/builders/WinBuilder.ts tests/unit/base-builder.test.tsgit diff --check