Skip to content

Move close icon to components in docs #28512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartijnCuppens merged 2 commits into from
May 10, 2019
Merged

Move close icon to components in docs #28512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb62df9
Move close icon to components
MartijnCuppens Mar 15, 2019
f2d1ed2
Remove redundant float from close
MartijnCuppens May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scss/_close.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.close {
float: right;
@include font-size($close-font-size);
font-weight: $close-font-weight;
line-height: 1;
Expand Down
2 changes: 1 addition & 1 deletion .../content/docs/4.3/utilities/close-icon.md → ...content/docs/4.3/components/close-icon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
layout: docs
title: Close icon
description: Use a generic close icon for dismissing content like modals and alerts.
group: utilities
group: components
---

**Be sure to include text for screen readers**, as we've done with `aria-label`.
Expand Down
2 changes: 1 addition & 1 deletion site/data/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- title: Button group
- title: Card
- title: Carousel
- title: Close icon
- title: Collapse
- title: Dropdowns
- title: Forms
Expand All @@ -56,7 +57,6 @@
pages:
- title: Borders
- title: Clearfix
- title: Close icon
- title: Colors
- title: Display
- title: Embed
Expand Down