Skip to content

Bump karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2#30731

Merged
XhmikosR merged 3 commits intomasterfrom
dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2
May 12, 2020
Merged

Bump karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2#30731
XhmikosR merged 3 commits intomasterfrom
dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 5, 2020

Bumps karma-coverage-istanbul-reporter from 2.1.1 to 3.0.2.

Changelog

Sourced from karma-coverage-istanbul-reporter's changelog.

3.0.2 (2020-05-05)

Bug Fixes

  • return correct exit code when thresholds are not met (that works with the karma api) (a0cbdd8), closes #80

3.0.1 (2020-05-04)

Bug Fixes

  • set correct process exit code when thresholds are not met (9ba3fe0), closes #80

3.0.0 (2020-05-01)

⚠ BREAKING CHANGES

  • node 6 and node 8 are no longer supported. To use this package you must upgrade to node 10 or higher.

Features

  • upgrade to latest istanbul api (28cbbfb)

Commits
  • 5f5ca05 chore(release): 3.0.2
  • a0cbdd8 fix: return correct exit code when thresholds are not met
  • e8d4f4a style: fix lint issue
  • 0d37f42 fix: wait for reports to finish writing before exiting karma
  • a50d4e5 chore(release): 3.0.1
  • e756c12 test: fix test exit code
  • 9ba3fe0 fix: set correct process exit code when thresholds are not met
  • b6632e2 test: remove deprecated mocha.opts file
  • 5304cd6 chore(release): 3.0.0
  • 31b1a40 chore: swap out newer istanbul loader
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@XhmikosR
Copy link
Member

XhmikosR commented May 5, 2020

@Johann-S I had a look at this and it seems with v3.x node_modules/popper.js/dist/esm popper.js is included in the coverage. I couldn't find a way to exclude node_modules/** from karma-coverage-istanbul-reporter in this new version.

Perhaps we could just use nyc for coverage if we can't make karma-coverage-istanbul-reporter to work?

Not high priority but we should look into it eventually.

@XhmikosR
Copy link
Member

XhmikosR commented May 9, 2020

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2 branch from 4d010fc to ff8bb12 Compare May 9, 2020 19:25
@dependabot-preview dependabot-preview bot requested a review from a team as a code owner May 9, 2020 19:34
@XhmikosR
Copy link
Member

XhmikosR commented May 9, 2020

This should be ready now @Johann-S

@XhmikosR XhmikosR merged commit fbdacc0 into master May 12, 2020
@XhmikosR XhmikosR deleted the dependabot/npm_and_yarn/karma-coverage-istanbul-reporter-3.0.2 branch May 12, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant