Fix dead variables-dark import in dormant SCSS mixin tests - #42746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two SCSS test files were importing a Sass partial (
variables-dark) that no longer exists in v6 — it was replaced by the new theme system. Because of that, these tests had quietly stopped running instead of failing loudly, so nobody noticed.Changes:
Note: Fixing one of the files uncovered a separate, pre-existing bug in an unrelated color-contrast helper function, which doesn't appear to be used anywhere else in the codebase. That's left untouched here and called out as a follow-up.