Skip to content

Add HTTP API Documentation#3

Merged
simeoncarstens merged 5 commits intotweag/http-apifrom
tweag/http-api-add-documentation
Feb 1, 2024
Merged

Add HTTP API Documentation#3
simeoncarstens merged 5 commits intotweag/http-apifrom
tweag/http-api-add-documentation

Conversation

@zz1874
Copy link
Collaborator

@zz1874 zz1874 commented Jan 31, 2024

Description

This PR introduces comprehensive documentation for the HTTP API, covering the main_endpoint and status endpoints. Additionally, code formatting has been applied.

Changes Made

  1. HTTP API Documentation:

    • Documented the main_endpoint providing details on its purpose.
    • Documented the status endpoint for retrieving job status.
  2. Code Formatting:

    • Applied code formatting using black.

How to Test

  1. Clone this branch.
  2. Run the application locally (the instruction is in api/README.md).
  3. Access the API documentation at /docs and /redoc endpoints to review the newly added documentation.

@zz1874 zz1874 requested a review from simeoncarstens January 31, 2024 03:28
Copy link
Member

@simeoncarstens simeoncarstens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! I made two small suggestions. Could you also add a paragraph / section in the main README that tells how to start the API, and mention the link to the auto-generated API docs site?

@zz1874 zz1874 requested a review from simeoncarstens February 1, 2024 08:10
zz1874 and others added 5 commits February 1, 2024 17:09
@simeoncarstens simeoncarstens force-pushed the tweag/http-api-add-documentation branch from 257e09d to 638479f Compare February 1, 2024 16:11
@simeoncarstens simeoncarstens merged commit 4e5090d into tweag/http-api Feb 1, 2024
simeoncarstens added a commit that referenced this pull request Feb 1, 2024
* Apply formatter

* Add documentation for `POST` and `GET` requests

* Update looper/api/main.py

Co-authored-by: Simeon Carstens <simeon.carstens@tweag.io>

* Update looper/api/main.py

Co-authored-by: Simeon Carstens <simeon.carstens@tweag.io>

* Add where to access the API documentation

---------

Co-authored-by: Simeon Carstens <simeon.carstens@tweag.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants