Fix issues around cc_wrapper with Cabal builds #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thufschmitt
approved these changes
Jun 4, 2020
To enable cc_wrapper to determine the path to the `_solib_<cpu>` directory also when executing outside the execroot directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_PATHon Windows. Since we don't use dynamic Haskell libraries on Windows, we can stick to a shorter build directory path on Windows.cc_wrapper's logic to fix RUNPATHs in temporary outputs of GHC didn't work in a working directory outside of the Bazel execroot as is the case in Cabal builds. This triggered build failures with intermediate outputs exceeding the MACH-O header size limit on MacOS, see Setup ghcide for rules_haskell repository #1262 (comment). This PR extends the corresponding logic in the cc_wrapper to look for the solib directory under the execroot which can be specified by Cabal wrapper via an environment variable.