Skip to content

Don't use deprecated struct methods #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2023
Merged

Don't use deprecated struct methods #2043

merged 3 commits into from
Nov 15, 2023

Conversation

@avdv
Copy link
Member

@avdv avdv commented Nov 14, 2023

Fixes #2040

@avdv avdv requested a review from ylecornec November 14, 2023 16:39
ylecornec
ylecornec approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ylecornec ylecornec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@avdv avdv added the merge-queue merge on green CI label Nov 15, 2023
@mergify mergify bot merged commit ceb156a into master Nov 15, 2023
@mergify mergify bot deleted the remove-deprecated-to_json branch November 15, 2023 09:40
@mergify mergify bot removed the merge-queue merge on green CI label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ylecornec ylecornec ylecornec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't use deprecated to_json on struct

3 participants

@avdv @ylecornec