ci: replace Travis with GitHub Actions #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have consistency I'm moving the different CIs slowly to GitHub Actions. It works better with our permissioning models. Long term we'll add publishing to this as well
You can't use incremental builds with the noEmit option so we are dropping it for now
dkundel
force-pushed
the
dkundel/add-actions-ci
branch
from
4eabfd6 to
eab870c
Compare
philnash
approved these changes
May 22, 2020
Contributor
philnash
left a comment
philnash
left a comment
There was a problem hiding this comment.
Seems good all round. Testing on Windows does love to throw your paths out 😄 I have a blog post for this one 😄
One question, you disabled incremental compilation in the base. Will that make local compilation slower? Was that for the tests? And could it be done in tsconfig.test.json?
This was referenced Dec 17, 2020
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have consistency I'm moving the different CIs slowly to GitHub Actions. It works better with our
permissioning models. Long term we'll add publishing to this as well
Contributing to Twilio