fix: shut down executorService thread automatically to allow the JVM to shut down gracefully#502
Merged
thinkingserious merged 2 commits intotwilio:masterfrom Mar 5, 2020
Salil999:thread_fix
Merged
fix: shut down executorService thread automatically to allow the JVM to shut down gracefully#502thinkingserious merged 2 commits intotwilio:masterfrom Salil999:thread_fix
thinkingserious merged 2 commits intotwilio:masterfrom
Salil999:thread_fix
Conversation
thinkingserious
changed the title
thinkingserious
changed the title
thinkingserious
added
difficulty: medium
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
…to shut down gracefully (twilio#502)
FalguniV
pushed a commit
to FalguniV/twilio-java
that referenced
this pull request
Oct 13, 2020
…to shut down gracefully (twilio#502)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
Initial attempt at trying to mitigate some threading issues in the Twilio API. I'm a bit new to open source, but I think this should try and help (or at least pave the initial steps) for issue #431
I didn't quite see the reason why a
booleanwas necessary (as mentioned by @bohnman in #431). Regardless if the executor service is set by the user or if it is generated internally, we should shutdown the executor service anyway, am I right?Oh, and I think there might have been a small typo in the
setUsernamemethod. I updated that as well.Contributing to Twilio