Conversation
ghost
mentioned this pull request
johnjacobkenny
requested review from
melissahuertadev,
michaelcosj,
pranavgoel29 and
thunder-coding
thunder-coding
suggested changes
Oct 18, 2020
thunder-coding
left a comment
thunder-coding
left a comment
Contributor
There was a problem hiding this comment.
Let it be the way it is.
I think hoisting all the images on Twindle repository will not be a good option as for changes in any image need to be addressed by a PR.
Contributor
|
I'm fine for now. |
ghost
closed this
ghost
deleted the
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added public folder to store images. changed the links in readme.md file.
If changes are fine, then readme needs to be updated with proper links pointing to main branch. (i haven't done so that people can preview how icons look like on https://github.com/codeprm/twindle/tree/issue-233)
Now it's like
https://raw.githubusercontent.com/codeprm/twindle/issue-233/public/social_icons/50px/twitter.png
Future should be like
https://raw.githubusercontent.com/twindle-co/twindle/main/public/social_icons/50px/twitter.png