Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Lookup app servers using multiple SRV records#42

Merged
roback merged 3 commits intomasterfrom
lookup-servers-using-multiple-srv-records
Oct 3, 2018
Merged

Lookup app servers using multiple SRV records#42
roback merged 3 commits intomasterfrom
lookup-servers-using-multiple-srv-records

Conversation

@roback
Copy link
Copy Markdown
Member

@roback roback commented Oct 2, 2018

Preparation for when we have two datacenters to deploy to.

Preparation for when we have two datacenters to deploy to.
@roback roback changed the title Lookup ruby servers using multiple SRV records Lookup app servers using multiple SRV records Oct 2, 2018
@roback
Copy link
Copy Markdown
Member Author

roback commented Oct 2, 2018

The test failing has nothing to do with this PR :)

  1) Net::SSH supports the ed25519 algorithm
     Failure/Error: expect(Net::SSH::Authentication::ED25519Loader::LOADED).to be(true)
     
       expected true
            got false
     # ./spec/integration/net_ssh_spec.rb:5:in `block (2 levels) in <top (required)>'

@dentarg
Copy link
Copy Markdown
Contributor

dentarg commented Oct 2, 2018

We should make the build green anyway :-) It was 10 months since we last ran the tests here, so I guess we haven't properly locked our dependencies, I think it would be good to do that

@dentarg
Copy link
Copy Markdown
Contributor

dentarg commented Oct 2, 2018

This was changed in net-ssh/net-ssh#563 (v.5.0).

bcrypt_pbkdf is still needed though:

> For ed25519 public key auth support your bundle file should contain
> “`ed25519“`, “`bcrypt_pbkdf“` dependencies.

(From https://github.com/net-ssh/net-ssh#install)
@roback
Copy link
Copy Markdown
Member Author

roback commented Oct 2, 2018

We should make the build green anyway :-)

Done! net-ssh/net-ssh#563 was the cause behind the failure :)

@dentarg
Copy link
Copy Markdown
Contributor

dentarg commented Oct 3, 2018

We also need to require net-ssh >= 5

$ bundle
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using bcrypt_pbkdf 1.0.0
Using bundler 1.16.1
Using ed25519 1.2.4
Using net-ssh 4.2.0
Bundle complete! 3 Gemfile dependencies, 4 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

~/Downloads/test
$ bundle exec ruby -e 'require "net/ssh"; p Net::SSH::Authentication::ED25519Loader::LOADED'
false
$ bundle
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using bcrypt_pbkdf 1.0.0
Using bundler 1.16.1
Using ed25519 1.2.4
Using net-ssh 5.0.2
Bundle complete! 3 Gemfile dependencies, 4 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

~/Downloads/test
$ bundle exec ruby -e 'require "net/ssh"; p Net::SSH::Authentication::ED25519Loader::LOADED'
true

References:

@roback
Copy link
Copy Markdown
Member Author

roback commented Oct 3, 2018

We also need to require net-ssh >= 5

Ah, yes, of course :)

Since c31beee we need to have net-ssh >= 5.

Also set an upper limit for the gem version for ed25519, as documented
at net-ssh/net-ssh#565.

See #42 (comment)
@roback roback merged commit 7c98cb2 into master Oct 3, 2018
@roback roback deleted the lookup-servers-using-multiple-srv-records branch October 3, 2018 10:51
roback added a commit that referenced this pull request Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants