This repository was archived by the owner on Jan 28, 2026. It is now read-only.
Lookup app servers using multiple SRV records#42
Merged
Conversation
Preparation for when we have two datacenters to deploy to.
Member
Author
|
The test failing has nothing to do with this PR :) |
Contributor
|
We should make the build green anyway :-) It was 10 months since we last ran the tests here, so I guess we haven't properly locked our dependencies, I think it would be good to do that |
Contributor
|
I suspect this change
|
This was changed in net-ssh/net-ssh#563 (v.5.0). bcrypt_pbkdf is still needed though: > For ed25519 public key auth support your bundle file should contain > “`ed25519“`, “`bcrypt_pbkdf“` dependencies. (From https://github.com/net-ssh/net-ssh#install)
Member
Author
Done! net-ssh/net-ssh#563 was the cause behind the failure :) |
Contributor
|
We also need to require net-ssh >= 5 References: |
Member
Author
Ah, yes, of course :) |
Since c31beee we need to have net-ssh >= 5. Also set an upper limit for the gem version for ed25519, as documented at net-ssh/net-ssh#565. See #42 (comment)
dentarg
approved these changes
Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for when we have two datacenters to deploy to.