Migration of tests in finagle-thrift and finagle-stream to ScalaTest#308
Closed
bajohns wants to merge 1 commit intotwitter:masterfrom
Closed
Migration of tests in finagle-thrift and finagle-stream to ScalaTest#308bajohns wants to merge 1 commit intotwitter:masterfrom
bajohns wants to merge 1 commit intotwitter:masterfrom
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
I would prefer having a standard class with members instead of default constructor arguments.
Contributor
|
Other than a few code style changes, it looks good to me. |
Contributor
|
Rad, we'll merge this in after you address Steve's comments :] I'm really excited about this! |
Contributor
|
@bajohns just wanted to make sure this didn't get lost in the shuffle 👍 |
Problem These two packages contain tests written in Specs2 and ScalaTest. Solution All tests in these packages were migrated to ScalaTest. Additionally, the ignore facility in ScalaTest was used to message when flaky tests are disable. Result These packages now conform to the Finagle testing stadard. Additionally, the ignore facility in ScalaTest was used to message when flaky tests are disabled.
bajohns
force-pushed
the
thrift-stream-to-scala-test
branch
from
61018f0 to
8757551
Compare
Contributor
Author
|
Hey @mosesn, Thanks for the ping - this did get lost in the shuffle. Given that the feedback was small I committed by amending. Please let me know if this version works better re: comments from @stevegury |
Contributor
|
This is committed internally and should be mirrored to github sometime this week. Thanks for the PR! |
Contributor
|
This is now on GitHub—thanks again, @bajohns! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
These two packages contain tests written in Specs2 and ScalaTest.
Solution
All tests in these packages were migrated to ScalaTest. Additionally, the ignore facility
in ScalaTest was used to message when flaky tests are disable.
Result
These packages now conform to the Finagle testing stadard. Additionally, the ignore facility
in ScalaTest was used to message when flaky tests are disabled.