feat(stelae): name the official registry's published read-only pair - #1186
Conversation
The constants #1184 shipped empty now carry the pair the deployed registry at oci.stelae.store issues: a fresh `dolos init` seeds `[stelae.registry] user = "stelae"` and the binary answers for the password, so a generated config pulls steles out of the box while the pair itself stays rotatable in one place. The password is the published read-only credential -- public by design, pull-only by enforcement -- and gates nothing but out-of-band tooling. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe official stelae registry user and password defaults are now populated in the initialization binary. Documentation describes credential rotation and confirms that generated TOML includes the user but omits the compiled password. ChangesOfficial registry configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/bin/dolos/init.rs (1)
820-840: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winExtend tests for the full credential contract.
This test covers fresh configuration output only. Add coverage that:
- Authenticates
OFFICIAL_REGISTRY_USERwithOFFICIAL_REGISTRY_PASSWORDwhen the file password is absent.- Preserves an existing configured password during a configuration round trip.
The existing
src/bin/dolos/common.rs:437-445test uses"dolos-reader", so it does not directly cover the newstelaedefault.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/bin/dolos/init.rs` around lines 820 - 840, Extend the configuration tests around a_fresh_config_seeds_the_official_registry_and_no_password to verify authentication uses OFFICIAL_REGISTRY_USER and OFFICIAL_REGISTRY_PASSWORD when the generated registry password is absent, and add a round-trip case confirming an explicitly configured registry password is preserved. Use the existing authentication test pattern from common.rs while covering the stelae default credentials directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/bin/dolos/init.rs`:
- Around line 820-840: Extend the configuration tests around
a_fresh_config_seeds_the_official_registry_and_no_password to verify
authentication uses OFFICIAL_REGISTRY_USER and OFFICIAL_REGISTRY_PASSWORD when
the generated registry password is absent, and add a round-trip case confirming
an explicitly configured registry password is preserved. Use the existing
authentication test pattern from common.rs while covering the stelae default
credentials directly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f53b2c26-a063-474f-b9cd-49e5c21d69e6
📒 Files selected for processing (1)
src/bin/dolos/init.rs
Plan
Brain/txpipeplan: dolos-stelae-cloudflare-registry — this is the hand-off that plan owed #1184: the registry now exists (oci.stelae.store, stockcloudflare/serverless-registryon Workers/R2, all nine validation gates passed), so the constants it issues stop being empty.What changed
The two-line change #1184 designed for, plus the doc lines that said "empty until the registry exists":
OFFICIAL_REGISTRY_USER = "stelae",OFFICIAL_REGISTRY_PASSWORD = <the published pair>insrc/bin/dolos/init.rs. The password is the published read-only credential — public by design (it will sit in every consumer's docs), pull-only by the registry's capability enforcement (capabilities: ["pull"]; verified as gate 7 of the deployment plan: an upload through it is refused with 401).A fresh
dolos initnow writes:and never a password — the binary supplies it (
stele_registry_auth), exactly as #1184 pinned.Verification
init::tests::a_fresh_config_seeds_the_official_registry_and_no_password,a_configured_password_survives_the_round_trip,common'sa_seeded_user_takes_the_compiled_in_password,the_section_names_a_user_a_token_or_nobody,two_identities_at_once_are_refused— all green (they were written to hold on the day the constants filled).curl -u stelae:… https://oci.stelae.store/v2/→200.cargo +nightly fmt --all -- --checkclean.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
stelaeusername.Documentation