Skip to content

Conversation

@fredevery
Copy link
Contributor

No description provided.

@fredevery fredevery changed the base branch from devel to issue-19 June 22, 2018 14:43
@fredevery fredevery changed the base branch from issue-19 to devel June 27, 2018 18:38
@fredevery fredevery changed the title DONUT - Issue 23 #23 (+ #24, #35, #36) - Toolbar configuration + refinements + bugs Jun 27, 2018
@fredevery fredevery requested a review from LevKanter June 27, 2018 18:40
Copy link
Contributor

@LevKanter LevKanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredevery tests pass and everything generally looks great, but I am running into a console error when, on the test page, I select the third paragraph and try to toggle the blockquote formatter:

image

@LevKanter LevKanter assigned fredevery and unassigned LevKanter Jun 28, 2018
@fredevery
Copy link
Contributor Author

@LevKanter I haven't managed to reproduce the issue locally. I did notice another issue (#38) that I am hoping is the reason for the issue you're seeing. Could you pull and retry?

If you still experience the issue could you give me full steps to repro? Please try list everything, it might be caused by a series of things.

@LevKanter
Copy link
Contributor

@fredevery thanks - I am still reproducing that issue after pulling/rebuilding/retrying.

The steps I'm taking are as follows:

  • After yarn build and yarn local_server, load the page http://localhost:4848/
  • Tripple click on the third paragraph to select it and bring up the toolbar:
    image
  • Toggle any of the block-level formatters (toggling 'bold' and 'italics' doesn't cause any problems). For example, toggle 'h1':
    image
    The error fires before it looks like any content markup is changed.

@LevKanter
Copy link
Contributor

@fredevery just curious, can you clarify what the no-open-tag and no-close-tag tags that have been added to the preview consoles are for?

@LevKanter LevKanter assigned fredevery and unassigned LevKanter Jul 5, 2018
@fredevery
Copy link
Contributor Author

@LevKanter As mentioned the blockquote range bug has a fix in the PR for issue 9.

The no-open-tag/no-close-tag tags are there as a visual debug aid, in case, for any reason tag pairs go awry.

@fredevery fredevery assigned LevKanter and unassigned fredevery Jul 6, 2018
@LevKanter LevKanter merged commit f880537 into devel Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants