Update tsconfig when in-repo addons are generated

[jamescdavis]

resolve #146

[chriskrycho]

This looks good to me overall. I’d love input from @dfreeman and/or @dwickern as well, as both have way more experience dealing with in-repo-addons than I do. I do also wonder if the "ember-cli": "*" constraint in the package.json will ever cause issues in terms of what gets installed and our test matrix. I don’t think so? But I’m not positive, and am thinking we should probably specify an actual version.

[jamescdavis]

Yeah, I'm wasn't happy with "ember-cli": "*" in dependencies, either. I moved to peerDependencies as this also pleases eslint, yet shouldn't ever affect what version gets installed.

I would, though, rather have even this specify version, but didn't initially because I wasn't sure of the minimum version ember-cli-typescript supports? "ember-cli": ">=2.12"? But maybe should be "ember-cli": "^2.12.0 || ~3.0.0" and then bump versions as each new ember-cli minor release tests clean? Or could go with "ember-cli": "^2.12.0 || ^3.0.0" and just assume it'll work until 4.0 (because, ya know, we all follow semver perfectly, right? ;).

[dfreeman]

This looks great! The one question I have is whether it's possible/reasonable to share any of the logic around setting up tsconfig.json for in-repo addons between this blueprint and the ember-cli-typescript one that's executed on installation. It may be that things are stable enough now that it's not a big deal, but currently this means we'll have to be diligent about updating both places if the details of that ever change.

As far as the ember-cli peerDep goes, I've just told ESLint I know better for the specific case of require()ing modules from ember-cli up to this point. Adding the peer dependency won't hurt anything, but realistically I think it's also not likely to catch erroneous installation states either, regardless of whether we go with * or a particular version range.

[jamescdavis]

@dfreeman I'm always a fan of DRYing things ups, so I moved the code for updating tsconfig.json paths to a utility and used it both in the in-repo-addon and ember-cli-typescript blueprints. I also added an option to the updatePathsForAddon utility that will do the right thing for linked addons so that we can use this for a command that sets up linked addons.

I agree that an ember-cli peer dependency doesn't really help much, so I've switched to eslint-disable-line node/no-unpublished-require.

[dfreeman]

@chriskrycho I know you're swamped this week, but if you happen to have a few minutes of downtime at some point, it looks like Appveyor just went out to lunch on the builds for this and #159 and never reported in, and I think you're the only person who can re-kick them.

[chriskrycho]

Doh. Yeah, nice call out; I’ll kick them in a few.

[chriskrycho]

Kicked. We'll see if it reports properly this time. If not, I'm just going to merge it, since it passes.