Generate functioning addon components #159
Conversation
jamescdavis
force-pushed
the
generate-functioning-addon-components
branch
from
4ed2470 to
7e19628
Compare
blueprints/component/index.js
Outdated
| importTemplate = 'import layout from \'' + templatePath + '\';\n'; | ||
| contents = '\n layout'; | ||
| importTemplate = '// @ts-ignore: Ignore import of compiled template\nimport layout from \'' + templatePath + '\';\n'; | ||
| contents = '\n layout = layout'; |
There was a problem hiding this comment.
[nit] Can we add a semicolon after = layout, since the blueprints tend not to rely on ASI?
|
Should I try to get generation of a type declaration working? I'm not sure we have the types yet that we would need to do this. I'm pretty sure it should be this, but I don't think that is published anywhere? Should I open a DefinitelyTyped PR to add it? Would it be appropriate to add a |
jamescdavis
force-pushed
the
generate-functioning-addon-components
branch
from
7e19628 to
4cec874
Compare
|
Yeah, it's just not reporting. :sigh: |
|
@jamescdavis I don't think I can get back far enough in the Slack history for that link 🙂 As far as I know, the exact contents of compiled templates aren't public API, so if we did expose a type for them, I'd be in favor of just making it an interface with a brand field. I do think generating declarations is an interesting idea. I'd love to have a chat at some point about how we can make generation work nicely throughout the ecosystem—things like ember-css-modules and ember-apollo-client (and I'm sure other addons) would likely benefit from having either something to plug into or an easy example to follow for producing declarations for their own generated modules. |
…omponents Generate functioning addon components
3 participants
Components generated in an addon are not currently functional because they are missing the manual setting of their layout property to their compiled template.