This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Add duplicate RP capabilities #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@adammitchelldev this is also blocked due to the order grakn core changes were merged, should be easy to roll into your upcoming client change :) |
Member
Author
|
You may also have to add james' inclusion of |
Contributor
|
Closing as these changes were merged in https://github.com/graknlabs/client-nodejs/pull/91 |
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-client-nodejs
that referenced
this pull request
Sep 1, 2023
## What is the goal of this PR? Introduce BDD testing for the explanations returned to the client. ## What are the changes implemented in this PR? - The major step introduced is `answers contain explanation tree`, which checks the full tree of nested explanations are as expected - This method is longer and more complicated than we would like, as a result of the nested structure that is being tested - Note that the major limitation of this testing is that it can only assert one of the possible reasoner resolution paths, and so the test examples need to be carefully picked so that there is only one path, or that the possible paths look identical. See [https://github.com/graknlabs/verification/pull/33](https://github.com/graknlabs/verification/pull/33) Fixes typedb#95
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Add duplicate RP capabilities following the style of client-python's change at typedb/typedb-driver-python#85
What are the changes implemented in this PR?