This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Allow duplicate role players #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…python into disable-role-put
Member
Author
|
@vmax sortedo out the ignored tests, feel free to review |
Member
Author
|
just kidding |
vmax
approved these changes
Apr 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Allowing duplicate roles to be played in a relation as of typedb/typedb#5667.
This means now that
relation.getRolePlayerMap()should return a map fromRoleto[Thing]rather thanset(Thing)What are the changes implemented in this PR?
rolePlayerMapin the concept API