On #4185 @smarter raised concerns about importing code into cats that is based on code from the Scala standard library.
However as @satorg pointed out there is already code in cats which is adapted from the Scala standard library, e.g.
https://github.com/typelevel/cats/blob/fe40bc2b4961386d829c0dd594af9bd80941947d/tests/shared/src/test/scala-2.12/cats/tests/compat/SeqOps.scala
https://github.com/typelevel/cats/blob/fe40bc2b4961386d829c0dd594af9bd80941947d/kernel/src/main/scala-2.13+/cats/kernel/compat/HashCompat.scala
We should ensure that the correct attribution notices are added to such code and that the redistribution requirements for that code are met.
On #4185 it was discussed that we should include the Apache license at the root of the cats repo, and add attribution notices to each file based on the scala/scala NOTICE file, as well as ensuring that the licences key of build.sbt is updated to include the Apache 2.0 license.
I don't know if that is enough to ensure that we are doing the right thing so hopefully someone else will chime in. 😛
On #4185 @smarter raised concerns about importing code into cats that is based on code from the Scala standard library.
However as @satorg pointed out there is already code in cats which is adapted from the Scala standard library, e.g.
https://github.com/typelevel/cats/blob/fe40bc2b4961386d829c0dd594af9bd80941947d/tests/shared/src/test/scala-2.12/cats/tests/compat/SeqOps.scala
https://github.com/typelevel/cats/blob/fe40bc2b4961386d829c0dd594af9bd80941947d/kernel/src/main/scala-2.13+/cats/kernel/compat/HashCompat.scala
We should ensure that the correct attribution notices are added to such code and that the redistribution requirements for that code are met.
On #4185 it was discussed that we should include the Apache license at the root of the cats repo, and add attribution notices to each file based on the scala/scala NOTICE file, as well as ensuring that the
licenceskey ofbuild.sbtis updated to include the Apache 2.0 license.I don't know if that is enough to ensure that we are doing the right thing so hopefully someone else will chime in. 😛