Partial revert of ff83d14 #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial revert of ff83d14
Contributor
|
Is there an issue related to JS tests not running. I do see how this change could cause different behavior, although I'm not entirely sure why. I'm comfortable reverting this as long as we have a way of seeing if this fixes a problem (and ideally a unit test). |
Contributor
|
Aha! I see that this was reported in #557. Sorry for the confusion! I'm fine merging this if it fixes the problem. It's also likely that we might want to cut a 1.14.2 release, since this issue could affect others too. |
Contributor
Author
|
Yes, this is related to #557. My fault for failing to mention that. |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar with this portion of the code base, so I'm not sure what the consequence of reverting this, but this change causes Scala.js tests to run again.