Skip to content

Conversation

@ashawley
Copy link
Contributor

This will likely be the only change in the release.

This is also an opportunity to fix up whitespace/wordwrap in the release notes.

Contributor list pulled with: git shortlog -ns --no-merges 1.14.1..HEAD

@ashawley ashawley added this to the 1.14.2 milestone Sep 21, 2019
@SethTisue
Copy link
Member

maybe this was laid out already and I missed it, but:

why bother releasing if there are no user-visible changes?

@ashawley
Copy link
Contributor Author

It's a bug fix release.

@SethTisue
Copy link
Member

SethTisue commented Sep 23, 2019

I'm still confused. What bug was fixed? You mean #557? Does #557 affect users, and not just CI?

I'm just not understanding how it's possible for both 1) "No user-visible changes" to be in the release notes, and 2) that the release is somehow worth doing regardless?

@ashawley
Copy link
Contributor Author

Yes, #557 is the bug. Yes, it happens locally for me, not just CI builds.

@ashawley
Copy link
Contributor Author

In case you missed it, Erik mentioned a 1.14.2 release in a comment in #558.

@SethTisue
Copy link
Member

Yes, it happens locally for me, not just CI builds

It happens locally for you during development work on ScalaCheck itself, only? Or it also happens when Scala.js users use 1.14.1 in their own projects?

@ashawley
Copy link
Contributor Author

Yes, it happens downstream when running Scala.js tests with 1.14.1.

@SethTisue
Copy link
Member

okay, clear now. some more direct wording such as "Doesn't work on Scala.js, tests don't run" might be clearer than "Scala.js tests are not being run"

@ashawley
Copy link
Contributor Author

ashawley commented Sep 23, 2019

Ok, that's a valid criticism. Yes, "doesn't work" is right, but I tried to be more specific. How about "Tests are not being run at all on Scala.js"? Better?

@ashawley ashawley force-pushed the release-notes-1.14.2 branch from c1b88ce to 4e418ce Compare September 23, 2019 16:03
@SethTisue
Copy link
Member

SethTisue commented Sep 23, 2019

perhaps it's simply that as a maintainer/contributor, I have ScalaCheck's own CI on the brain. perhaps actual users won't have the same understanding problem I did

in any case: as you see fit, now that we understand each other.

@non
Copy link
Contributor

non commented Sep 25, 2019

@ashawley Want to mark this as released and merge it now?

@ashawley ashawley changed the title Draft release notes for 1.14.2 Release notes for 1.14.2 Sep 26, 2019
@ashawley ashawley force-pushed the release-notes-1.14.2 branch from 4e418ce to 44e614e Compare September 26, 2019 00:21
@ashawley
Copy link
Contributor Author

Sure thing. Marked as released and merging.

@ashawley ashawley merged commit 66558ac into typelevel:master Sep 26, 2019
@ashawley ashawley deleted the release-notes-1.14.2 branch September 26, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants