-
-
Notifications
You must be signed in to change notification settings - Fork 402
Release notes for 1.14.2 #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
maybe this was laid out already and I missed it, but: why bother releasing if there are no user-visible changes? |
|
It's a bug fix release. |
|
Yes, #557 is the bug. Yes, it happens locally for me, not just CI builds. |
|
In case you missed it, Erik mentioned a 1.14.2 release in a comment in #558. |
It happens locally for you during development work on ScalaCheck itself, only? Or it also happens when Scala.js users use 1.14.1 in their own projects? |
|
Yes, it happens downstream when running Scala.js tests with 1.14.1. |
|
okay, clear now. some more direct wording such as "Doesn't work on Scala.js, tests don't run" might be clearer than "Scala.js tests are not being run" |
|
Ok, that's a valid criticism. Yes, "doesn't work" is right, but I tried to be more specific. How about "Tests are not being run at all on Scala.js"? Better? |
c1b88ce to
4e418ce
Compare
|
perhaps it's simply that as a maintainer/contributor, I have ScalaCheck's own CI on the brain. perhaps actual users won't have the same understanding problem I did in any case: as you see fit, now that we understand each other. |
|
@ashawley Want to mark this as released and merge it now? |
4e418ce to
44e614e
Compare
|
Sure thing. Marked as released and merging. |
This will likely be the only change in the release.
This is also an opportunity to fix up whitespace/wordwrap in the release notes.
Contributor list pulled with:
git shortlog -ns --no-merges 1.14.1..HEAD