otel4s: introduce Telemetry - #1355
Merged
Merged
Conversation
iRevive
commented
Aug 31, 2026
|
|
||
| config.captureQuery.queryParametersPolicy match { | ||
| case QueryCaptureConfig.QueryParametersPolicy.All => | ||
| redactionStrategy.redactArguments(arguments).zipWithIndex.foreach { |
Contributor
Author
There was a problem hiding this comment.
First, we redact arguments when we build a query; then we redact them again here.
The same has been happening before my changes.
Any reason to try to redact arguments once?
Member
There was a problem hiding this comment.
No, I think when redaction was initially added, there wasn't a great place to do it once
iRevive
force-pushed
the
topic/otel4s-query-analyzer
branch
from
August 31, 2026 11:40
803bd87 to
7dbbe72
Compare
iRevive
force-pushed
the
topic/otel4s-query-analyzer
branch
from
September 4, 2026 17:00
7dbbe72 to
34bfb51
Compare
iRevive
commented
Sep 4, 2026
Member
|
This looks great! Super excited to land this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #1352.
Key changes
TelemetryConfigwhich allows customization. Secondly,Telemetryis a centralized telemetry hub.I think we can split this PR into smaller pieces if needed.
Some boilerplate changes were implemented by codex.