Skip to content

Add hero section to main template with event links and styled layout#669

Closed
dhinojosa wants to merge 2 commits into
typelevel:mainfrom
dhinojosa:feat/homepage-announcement-banner
Closed

Add hero section to main template with event links and styled layout#669
dhinojosa wants to merge 2 commits into
typelevel:mainfrom
dhinojosa:feat/homepage-announcement-banner

Conversation

@dhinojosa

Copy link
Copy Markdown

Here you go Antonio, what needs to be done is up to you as well.

@reardonj

Copy link
Copy Markdown
Contributor

@dhinojosa , would it be possible to include a screenshot so we can see what it looks like without a local build?

@dhinojosa

Copy link
Copy Markdown
Author

Oh no. How did it get over here. It is still in development. Antonio is going to slice and dice it some more. But yes. I can screen shot it for the team.

@reardonj

Copy link
Copy Markdown
Contributor

Oh no. How did it get over here. It is still in development. Antonio is going to slice and dice it some more. But yes. I can screen shot it for the team.

haha. No worries. I can wait until it’s ready.

Comment thread .gitignore
.vscode

target/
.idea/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find yourself adding this to all your .gitignores, consider using a global .gitignore config instead. I see this repo also has a .vscode exclusion so no objection to leaving this change 🙃, but it’s good practice for more unusual local tools polluting git repos

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? If .idea goes, so does .vscode! 😂 I'll consider the global one, though. I suspected that most of the group are MetalHeads.

Also, last night I saw your message and thought I had merged it by mistake; this morning I saw I hadn't. I see what I did; I was trying to do a PR to Antonio's fork, but it ended up here. Hmm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global is nice so you don’t have to keep doing it every time you touch a new repo more than anything.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, made a mistake yesterday. I didn't mean to do a PR here, but to Antonio's. Closed for now. Antonio or I will make a formal one here very soon. Thanks @reardonj

.idea for life! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants