Model machines with one typed root and simplify React ownership - #206
Merged
Conversation
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Machines now have one explicit
Machine.stateroot passed toMachine.make({ root }). Root fields support data-only machines and shared data that survives child transitions. Declared defaults initialize the topology;initialConfigurationseparately constructs a complete startup override. Root handlers, direct constructors, non-reentering value updates, and guarded transitions reduce authoring ceremony while preserving typed topology, ownership, and initialization requirements.The generic and indexed runtimes, history, completion, persistence, tests, and integrations use the root snapshot model. Public, internal, and emitted event protocols have fields constructors and explicit schema-import constructors. Tests accept the same deferred event inputs as production. Encoded snapshots move to version 2.
React gains typed
MachineStaterendering andcreateMachineContext(AtomMachine.factory(machine))with isolated Provider ownership and startup-only input. Atom bridges exposeresultandsnapshot; coreMachineRef.stateremains available. The root API guide and package examples cover direct migration. Devtools, lint rules, and benchmark adapters follow the new definition shape.Changeset
Validation
pnpm checkLocal type-performance budgets remain unchanged. The CI comparison shows lower compiler work in complex composition, invocation, branch, and adapter cases; small root definitions and the two-transition handler fixture cost more while staying within their budgets. Focused coverage includes root initialization and reuse, guards, deferred event receipts, generic-versus-indexed execution, retained snapshots, parallel conflicts, and React ownership under StrictMode. Snapshot construction reuses immutable topology builders while keeping every startup value and configuration independent. The final five-run CI comparison passes the unchanged runtime and memory guards. Single-machine startup remains 14.1% slower than the base, within the 15% guard; the full CI report records the remaining tradeoffs.