Conversation
Member
LeoColman
commented
Apr 5, 2025
LeoColman
commented
- Attempts to retrieve a GitHub App Installation token first
- Falls back to GITHUB_TOKEN if the installation token fails
- Logs a warning on failure of installation token retrieval
- Updated KDocs for both getGithubAuthToken and getGithubAuthTokenOrNull
3 tasks
Member
Author
|
We're missing adding a metric to count the amount of failures. The problem is: We don't have access to Prometheus registry here, so it's not trivial to create a Counter Should we move Prometheus to the Common module? Should we add a |
Member
|
@LeoColman for now I'd rather do it with the callback, to depend on Prometheus only in the server module. |
Member
Author
|
@krzema12 Taking a closer look makes me think that won't be possible.
So we either give up on metrics for a specific module or we move the prometheus config |
krzema12
reviewed
Apr 5, 2025
- Attempts to retrieve a GitHub App Installation token first - Falls back to GITHUB_TOKEN if the installation token fails - Logs a warning on failure of installation token retrieval - Updated KDocs for both getGithubAuthToken and getGithubAuthTokenOrNull
LeoColman
force-pushed
the
1880-chore-add-fallback-to-personal-access-token-if-installation-access-token-fails-for-whichever-reason
branch
from
90306be to
f13a8cf
Compare
3 tasks
krzema12
deleted the
1880-chore-add-fallback-to-personal-access-token-if-installation-access-token-fails-for-whichever-reason
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.