Skip to content

feat(server): add fallback to GITHUB_TOKEN if installation token fails #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzema12 merged 2 commits into from
Apr 5, 2025
Merged

feat(server): add fallback to GITHUB_TOKEN if installation token fails #1887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13a8cf
feat(server): add fallback to GITHUB_TOKEN if installation token fails
LeoColman Apr 5, 2025
b4f42ef
refactor: simplify GitHub auth token retrieval logic
LeoColman Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...nternal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/GithubUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
package io.github.typesafegithub.workflows.shared.internal

import io.github.oshai.kotlinlogging.KotlinLogging.logger
import kotlinx.coroutines.runBlocking

private val logger = logger { }

/**
* Returns a token that should be used to make authorized calls to GitHub,
* or null if no token was configured.
Expand All @@ -10,13 +13,10 @@ import kotlinx.coroutines.runBlocking
*/
fun getGithubAuthTokenOrNull(): String? =
runBlocking {
(System.getenv("GITHUB_TOKEN") ?: getInstallationAccessToken())
.also {
if (it == null) {
println(ERROR_NO_CONFIGURATION)
Comment thread
krzema12 marked this conversation as resolved.
}
}
}
runCatching { getInstallationAccessToken() }
.onFailure { logger.warn(it) { "Failed to get GitHub App Installation token, falling back to GITHUB_TOKEN." } }
.getOrNull() ?: System.getenv("GITHUB_TOKEN")
}.also { if (it == null) logger.warn { ERROR_NO_CONFIGURATION } }

/**
* Returns a token that should be used to make authorized calls to GitHub,
Expand Down
Loading