fix(types): correct type reference in CollectionFieldSchema #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `CollectionFieldSchema` to extend properties from `BaseCollectionCreateSchema` instead of `CollectionCreateSchema` - Export `BaseCollectionCreateSchema` interface to make it accessible - Fix imports in Collection.ts to use the correct types
Member
|
Published in v2.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Addresses #269.
This pull request includes several changes to the
Typesensemodule to improve type definitions and imports. The most important changes include modifying type imports inCollection.tsand exporting theBaseCollectionCreateSchemainterface inCollections.ts.Improvements to type definitions and imports:
src/Typesense/Collection.ts: Modified imports to separately importBaseCollectionCreateSchemaandCollectionCreateSchemafromCollections.ts.src/Typesense/Collection.ts: UpdatedCollectionFieldSchemato useBaseCollectionCreateSchemainstead ofCollectionCreateSchemafortoken_separatorsandsymbols_to_indexproperties.src/Typesense/Collections.ts: Exported theBaseCollectionCreateSchemainterface to allow its use in other files.PR Checklist