Skip to content

Conversation

@blaugold
Copy link
Contributor

@blaugold blaugold commented Aug 8, 2020

This PR adds always and strictGroups options to ValidationOptions.

always allows users to set a global default for decorators which do not specify that option. Before, the default was fixed and set to false.

When strictGroups is true, decorators with the groups option will not be considered when validating without groups.

references #60

@blaugold blaugold force-pushed the feature/new-validator-options branch from 3112023 to cf8b150 Compare August 8, 2020 15:16
@blaugold blaugold changed the title feat(ValidationOptions): add always & strictGroups feat: add always & strictGroups to ValidationOptions Aug 8, 2020
@blaugold blaugold force-pushed the feature/new-validator-options branch from cf8b150 to 274405f Compare August 8, 2020 16:18
Copy link
Member

@NoNameProvided NoNameProvided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will still need to check this out and check the test coverage before merging.

@NoNameProvided NoNameProvided merged commit 5fc23be into typestack:develop Aug 22, 2020
@NoNameProvided
Copy link
Member

Thanks!

tldrd0117 pushed a commit to tldrd0117/class-validator that referenced this pull request Sep 7, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants