Skip to content

Improve YAML formatting#7323

Merged
mernst merged 1 commit intotypetools:masterfrom
mernst:yaml-format
Oct 13, 2025
Merged

Improve YAML formatting#7323
mernst merged 1 commit intotypetools:masterfrom
mernst:yaml-format

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented Oct 13, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

This PR restructures CI configurations across Azure Pipelines, M4 templates, CircleCI, and Travis. It makes Azure pipelines explicit with per-JDK job variants (including JDK 25), rewires dependencies so non-canary jobs depend on their *_jdk25 counterparts, and expands jobs into detailed blocks with pools, containers, timeouts, and steps. M4 files are reformatted to generate explicit job hierarchies and dependencies; new job invocations (e.g., inference_job(canary_version), misc_job(25)) are added. CircleCI and Travis YAMLs are corrected for indentation and comment handling without changing command semantics.

Possibly related PRs

  • Simplify non-helper .m4 files #7281: Updates CI job definitions and M4 macros, adding/splitting per-JDK jobs (including *_part1/_part2 and JDK25 variants) similar to this PR’s restructuring.
  • Add jobs.m4 file #7270: Modifies .azure/jobs.m4 and defs.m4 to expand per-JDK job invocations and dependencies, paralleling this PR’s Azure job generation changes.
  • CI: don't run JDK 24 jobs #7266: Replaces JDK24 with JDK25 job variants and updates dependsOn graphs in Azure Pipelines, matching this PR’s JDK25-focused rewiring.

Suggested reviewers

  • smillst

Pre-merge checks and finishing touches

✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5da9d2 and d1b0636.

📒 Files selected for processing (8)
  • .azure/azure-pipelines-daily.yml (1 hunks)
  • .azure/azure-pipelines-daily.yml.m4 (3 hunks)
  • .azure/azure-pipelines.yml (1 hunks)
  • .azure/azure-pipelines.yml.m4 (1 hunks)
  • .azure/defs.m4 (1 hunks)
  • .azure/jobs.m4 (2 hunks)
  • .circleci/config.yml (17 hunks)
  • .travis.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: typetools.checker-framework (typecheck_part2_jdk25)
  • GitHub Check: typetools.checker-framework (typecheck_part1_jdk25)
  • GitHub Check: typetools.checker-framework (misc_jdk25)
  • GitHub Check: typetools.checker-framework (inference_part2_jdk25)
  • GitHub Check: typetools.checker-framework (nonjunit_jdk25)
  • GitHub Check: typetools.checker-framework (inference_part1_jdk25)
  • GitHub Check: typetools.checker-framework (junit_jdk25)

Comment thread .azure/azure-pipelines-daily.yml
Comment thread .azure/azure-pipelines-daily.yml
Comment thread .azure/azure-pipelines.yml.m4
Comment thread .azure/defs.m4
Comment thread .azure/defs.m4
@mernst mernst merged commit f07757c into typetools:master Oct 13, 2025
20 checks passed
@mernst mernst deleted the yaml-format branch October 13, 2025 12:40
@coderabbitai coderabbitai Bot mentioned this pull request Mar 2, 2026
This was referenced Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant