Skip to content

Rename class flow methods#7329

Merged
smillst merged 1 commit intotypetools:masterfrom
mernst:flow-analysis-class-naming
Oct 15, 2025
Merged

Rename class flow methods#7329
smillst merged 1 commit intotypetools:masterfrom
mernst:flow-analysis-class-naming

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented Oct 14, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 14, 2025

📝 Walkthrough

Walkthrough

This change renames two flow-analysis methods in GenericAnnotatedTypeFactory: performFlowAnalysis(ClassTree) to performFlowAnalysisForClass(ClassTree) and checkAndPerformFlowAnalysis(Tree) to performFlowAnalysisForClassOnce(ClassTree). Call sites are updated to use the new per-class method names and, where applicable, now pass ClassTree instead of Tree. Documentation and comments are revised to reference the new names, and docs/CHANGELOG.md records the API renames. No behavioral changes are indicated.

Suggested reviewers

  • smillst

Pre-merge checks and finishing touches

✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7599dee and c90194e.

📒 Files selected for processing (2)
  • docs/CHANGELOG.md (1 hunks)
  • framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java (6 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java (1)
javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java (1)
  • TreeUtils (116-2967)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: typetools.checker-framework (typecheck_part2_jdk25)
  • GitHub Check: typetools.checker-framework (junit_jdk25)
  • GitHub Check: typetools.checker-framework (typecheck_part1_jdk25)
  • GitHub Check: typetools.checker-framework (inference_part2_jdk25)
  • GitHub Check: typetools.checker-framework (misc_jdk25)
  • GitHub Check: typetools.checker-framework (nonjunit_jdk25)
  • GitHub Check: typetools.checker-framework (inference_part1_jdk25)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smillst smillst merged commit 2cf8c3f into typetools:master Oct 15, 2025
20 checks passed
@smillst smillst deleted the flow-analysis-class-naming branch October 15, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants