Skip to content

Don't refer to private method#7618

Merged
smillst merged 2 commits intotypetools:masterfrom
mernst:long-to-unsigned-big-integer
Apr 6, 2026
Merged

Don't refer to private method#7618
smillst merged 2 commits intotypetools:masterfrom
mernst:long-to-unsigned-big-integer

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented Apr 5, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d0e62c2f-c9df-4b51-8bc4-087c9acd0b5a

📥 Commits

Reviewing files that changed from the base of the PR and between cffe9a5 and c72e124.

📒 Files selected for processing (1)
  • checker-util/src/main/java/org/checkerframework/checker/signedness/util/SignednessUtil.java

📝 Walkthrough

Walkthrough

This change updates the Javadoc for the toUnsignedBigInteger(@unsigned long) method in SignednessUtil.java. The documentation was revised to remove a reference to reimplementing Java 8's Long#toUnsignedBigInteger(long) method and instead clarifies that Java provides no public method with equivalent functionality. Explicit @param and @return documentation tags were added. No executable code, control flow, or method behavior was modified. The change consists of 4 lines added and 2 lines removed.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smillst smillst merged commit f8311ea into typetools:master Apr 6, 2026
22 checks passed
@smillst smillst deleted the long-to-unsigned-big-integer branch April 6, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants