Skip to content

Keep the module-info when generating checker-qual-android#7653

Merged
smillst merged 5 commits intotypetools:masterfrom
marko-bekhta:fix/keep-module-info-for-android-qual
Apr 23, 2026
Merged

Keep the module-info when generating checker-qual-android#7653
smillst merged 5 commits intotypetools:masterfrom
marko-bekhta:fix/keep-module-info-for-android-qual

Conversation

@marko-bekhta
Copy link
Copy Markdown
Contributor

Hey 👋🏻 🙂

we'd want to use the -android version of the annotations to not have them at runtime, but at the same time we are looking into making things work with JPMS, and while at that I've noticed that -android was missing a module info file and had no automatic module name ...

any reason to skip the module info for the version of the annotation lib?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e39d5c60-9285-469b-b965-d1818f6ae937

📥 Commits

Reviewing files that changed from the base of the PR and between 7ff100f and 8f54293.

📒 Files selected for processing (2)
  • checker-qual-android/build.gradle
  • docs/manual/contributors.tex

📝 Walkthrough

Walkthrough

The pull request updates checker-qual-android/build.gradle to stop excluding module-info.java in the copySources task (so module descriptor sources are copied) and sets javadoc.modularity.inferModulePath = false. It also adds Marko Bekhta to docs/manual/contributors.tex. No changes to public APIs or exported declarations.

Possibly related PRs

Suggested reviewers

  • mernst
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

mernst
mernst previously approved these changes Apr 22, 2026
Copy link
Copy Markdown
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@checker-qual-android/build.gradle`:
- Around line 7-8: The include pattern include("**/*.java") already matches
module-info.java so remove the redundant include("**/module-info.java") entry;
keep the more general include("**/*.java") and drop the specific include to
avoid confusion (this is the extra line added that should be deleted).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 92461d4f-1e7a-41a5-a611-78a143163b31

📥 Commits

Reviewing files that changed from the base of the PR and between 4912950 and 7ff100f.

📒 Files selected for processing (2)
  • checker-qual-android/build.gradle
  • docs/manual/contributors.tex

Comment thread checker-qual-android/build.gradle Outdated
@smillst smillst enabled auto-merge (squash) April 23, 2026 15:54
@smillst smillst merged commit 1a2748e into typetools:master Apr 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants