Keep the module-info when generating checker-qual-android#7653
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request updates Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@checker-qual-android/build.gradle`:
- Around line 7-8: The include pattern include("**/*.java") already matches
module-info.java so remove the redundant include("**/module-info.java") entry;
keep the more general include("**/*.java") and drop the specific include to
avoid confusion (this is the extra line added that should be deleted).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 92461d4f-1e7a-41a5-a611-78a143163b31
📒 Files selected for processing (2)
checker-qual-android/build.gradledocs/manual/contributors.tex
Hey 👋🏻 🙂
we'd want to use the
-androidversion of the annotations to not have them at runtime, but at the same time we are looking into making things work with JPMS, and while at that I've noticed that-androidwas missing a module info file and had no automatic module name ...any reason to skip the module info for the version of the annotation lib?