Comment out uses of SideEffectsOnly

[mernst]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ce4fa181-7fb9-4313-bebd-dc7b2af4f88c

📥 Commits

Reviewing files that changed from the base of the PR and between e16b2f7 and 5e15bad.

📒 Files selected for processing (71)

• src/java.base/share/classes/java/io/BufferedReader.java
• src/java.base/share/classes/java/lang/AbstractStringBuilder.java
• src/java.base/share/classes/java/lang/CharSequence.java
• src/java.base/share/classes/java/lang/StackStreamFactory.java
• src/java.base/share/classes/java/lang/String.java
• src/java.base/share/classes/java/lang/StringBuffer.java
• src/java.base/share/classes/java/lang/StringBuilder.java
• src/java.base/share/classes/java/lang/StringLatin1.java
• src/java.base/share/classes/java/lang/StringUTF16.java
• src/java.base/share/classes/java/lang/invoke/AbstractConstantGroup.java
• src/java.base/share/classes/java/net/URL.java
• src/java.base/share/classes/java/nio/charset/Charset.java
• src/java.base/share/classes/java/nio/file/FileTreeIterator.java
• src/java.base/share/classes/java/nio/file/Files.java
• src/java.base/share/classes/java/nio/file/Path.java
• src/java.base/share/classes/java/util/AbstractList.java
• src/java.base/share/classes/java/util/AbstractMap.java
• src/java.base/share/classes/java/util/ArrayDeque.java
• src/java.base/share/classes/java/util/ArrayList.java
• src/java.base/share/classes/java/util/Arrays.java
• src/java.base/share/classes/java/util/Collections.java
• src/java.base/share/classes/java/util/Enumeration.java
• src/java.base/share/classes/java/util/HashMap.java
• src/java.base/share/classes/java/util/HashSet.java
• src/java.base/share/classes/java/util/Hashtable.java
• src/java.base/share/classes/java/util/IdentityHashMap.java
• src/java.base/share/classes/java/util/ImmutableCollections.java
• src/java.base/share/classes/java/util/Iterator.java
• src/java.base/share/classes/java/util/JumboEnumSet.java
• src/java.base/share/classes/java/util/LinkedHashMap.java
• src/java.base/share/classes/java/util/LinkedList.java
• src/java.base/share/classes/java/util/List.java
• src/java.base/share/classes/java/util/ListIterator.java
• src/java.base/share/classes/java/util/PriorityQueue.java
• src/java.base/share/classes/java/util/RegularEnumSet.java
• src/java.base/share/classes/java/util/Scanner.java
• src/java.base/share/classes/java/util/ServiceLoader.java
• src/java.base/share/classes/java/util/Spliterators.java
• src/java.base/share/classes/java/util/TreeMap.java
• src/java.base/share/classes/java/util/Vector.java
• src/java.base/share/classes/java/util/WeakHashMap.java
• src/java.base/share/classes/java/util/concurrent/ArrayBlockingQueue.java
• src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java
• src/java.base/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java
• src/java.base/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java
• src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
• src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
• src/java.base/share/classes/java/util/concurrent/DelayQueue.java
• src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java
• src/java.base/share/classes/java/util/concurrent/LinkedBlockingQueue.java
• src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
• src/java.base/share/classes/java/util/concurrent/PriorityBlockingQueue.java
• src/java.base/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java
• src/java.base/share/classes/java/util/regex/Matcher.java
• src/java.base/share/classes/java/util/regex/Pattern.java
• src/java.base/share/classes/java/util/zip/ZipFile.java
• src/java.base/share/classes/javax/security/auth/Subject.java
• src/java.base/share/classes/jdk/internal/icu/text/Replaceable.java
• src/java.base/share/classes/jdk/internal/icu/text/ReplaceableString.java
• src/java.base/share/classes/sun/net/www/HeaderParser.java
• src/java.base/share/classes/sun/net/www/MessageHeader.java
• src/java.base/share/classes/sun/security/jca/ProviderList.java
• src/java.base/share/classes/sun/util/PreHashedMap.java
• src/java.base/share/classes/sun/util/locale/StringTokenIterator.java
• src/java.base/share/classes/sun/util/resources/ParallelListResourceBundle.java
• src/java.base/unix/classes/java/lang/ProcessEnvironment.java
• src/java.base/unix/classes/sun/nio/fs/UnixDirectoryStream.java
• src/java.base/unix/classes/sun/nio/fs/UnixFileSystem.java
• src/java.base/windows/classes/java/lang/ProcessEnvironment.java
• src/java.base/windows/classes/sun/nio/fs/WindowsDirectoryStream.java
• src/java.base/windows/classes/sun/nio/fs/WindowsFileSystem.java

---

📝 Walkthrough

Walkthrough

This PR systematically comments out all usage of the Checker Framework @SideEffectsOnly annotation import and declarations across 70+ files in the java.base module. The changes disable the annotation without modifying any method signatures, runtime logic, or functional behavior. The annotation appears on iterator hasNext() methods, mutator methods, string manipulation methods, and various collection framework classes across core utilities, concurrent collections, I/O, NIO, and platform-specific implementations.

Possibly related PRs

• typetools/jdk#265: Directly related at the annotation level—both PRs modify @SideEffectsOnly declarations on java.lang.String and java.lang.StringBuffer getChars(...) methods, though in opposite directions.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 51.68% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.2)

src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}