Renamed shape to array shape, removed useless types methods - #18
Merged
Conversation
aivchen
requested changes
Sep 28, 2023
aivchen
approved these changes
Sep 28, 2023
the-toster
approved these changes
Sep 29, 2023
klimick
reviewed
Sep 29, 2023
| $_emptyShape = extractType(new ArrayShapeType()); | ||
|
|
||
| /** @var ArrayShapeType<array{a?: string, 10: int}> */ | ||
| $_shapeType = new ArrayShapeType([ |
Member
There was a problem hiding this comment.
Does this test really work?
This type cannot be inferred without a plugin.
Member
Author
There was a problem hiding this comment.
It doesn't, that's why there is a @var forced type above :)
klimick
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly needed in preparation for ObjectShape.