Skip to content

Conversation

@collierrgbsitisfise
Copy link

No description provided.

@collierrgbsitisfise collierrgbsitisfise changed the title Update troubleshoot according not executable docs: update troubleshoot according not executable scripts Jul 31, 2024
@typicode
Copy link
Owner

typicode commented Jul 31, 2024

Except if a bug, there's no need for them to be executable anymore.
Edit: need to check the other PR actually...

@collierrgbsitisfise
Copy link
Author

Except if a bug, there's no need for them to be executable anymore. Edit: need to check the other PR actually...

@typicode why exactly "there's no need for them to be executable anymore"? When it was changed, probably i missed something 😅. Thx in advance!

@typicode
Copy link
Owner

typicode commented Aug 1, 2024

Sure, this code sh -e "$s" "$@" runs the hook script even if it's not executable.

Previously (before v9) it's true that, for example, .husky/pre-commit had to be executable. It was creating problems for people creating hooks on Windows due to missing executable permission.

@collierrgbsitisfise
Copy link
Author

closing this PR, cause it's not actual for latest version

@collierrgbsitisfise collierrgbsitisfise deleted the update-troubleshoot-according-not-executable branch August 2, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants