Skip to content

Fix code injection alerts; Remove phpstan-command #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangrufus merged 1 commit into from
Apr 11, 2026
Merged

Fix code injection alerts; Remove phpstan-command #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/format-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ jobs:
- run: pint
shell: bash

- run: pint ${{ inputs.pint-extra-paths }}
- run: pint "$PINT_EXTRA_PATHS"
if: ${{ inputs.pint-extra-paths != '' }}
shell: bash
env:
PINT_EXTRA_PATHS: ${{ inputs.pint-extra-paths }}
Comment on lines +60 to +64
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pint "$PINT_EXTRA_PATHS" changes behavior compared to the previous pint ${{ inputs.pint-extra-paths }}: quoting prevents word-splitting and glob expansion, so callers can no longer pass multiple paths/patterns (e.g., space-separated paths or globs). If multi-path support is needed, consider expanding the env var into a bash array (or otherwise parsing/validating) and passing the resulting arguments to pint without re-introducing expression interpolation.

Copilot uses AI. Check for mistakes.

- uses: typisttech/create-auto-merged-pull-request-action@05e85fff478e9ff9dfbb4b6d95622b6a8ebafe78 # v0.2.0
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/go-proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
with:
cache: false

- run: go list -m -u -json -x github.com/${{ github.repository }}@${{ github.sha }}
- run: go list -m -u -json -x github.com/${{ github.repository }}@${{ github.ref_name }}
- run: go list -m -u -json -x "github.com/$GITHUB_REPOSITORY@$GITHUB_SHA"
- run: go list -m -u -json -x "github.com/$GITHUB_REPOSITORY@$GITHUB_REF_NAME"
continue-on-error: true
6 changes: 1 addition & 5 deletions .github/workflows/lint-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ on:
description: Whether to run phpstan
default: true
type: boolean
phpstan-command:
description: Command to run phpstan
default: 'vendor/bin/phpstan analyse --error-format=github'
type: string

# box
box:
Expand Down Expand Up @@ -74,7 +70,7 @@ jobs:
with:
dependency-versions: ${{ matrix.dependency-versions }}

- run: ${{ inputs.phpstan-command }}
- run: vendor/bin/phpstan analyse --error-format=github

box:
if: ${{ inputs.box }}
Expand Down
Loading