Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
name: build (${{ matrix.runs-on }})
needs: phar
strategy:
matrix:
matrix: &matrix
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions does not support YAML anchors and aliases. While the YAML syntax &matrix is valid YAML, GitHub Actions workflow parser will not process this anchor, and the subsequent alias reference *matrix on line 160 will fail. This will cause the workflow to fail when it runs.

To avoid duplication, consider one of these alternatives:

  1. Use a reusable workflow to share common matrix configurations
  2. Keep the matrix definition duplicated in both jobs (current working approach)
  3. Use a composite action if the entire job logic can be shared

Copilot uses AI. Check for mistakes.
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
Expand Down Expand Up @@ -157,16 +157,7 @@ jobs:
name: e2e (${{ matrix.runs-on }})
needs: build
strategy:
matrix:
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
- runs-on: ubuntu-24.04
variant: linux_amd64
- runs-on: macos-15
variant: darwin_arm64
- runs-on: macos-15-intel
variant: darwin_amd64
matrix: *matrix
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This YAML alias reference *matrix will not work in GitHub Actions workflows. GitHub Actions does not support YAML anchors and aliases, so this reference to the anchor defined on line 90 will fail, causing the workflow to error.

The matrix configuration needs to be explicitly defined here, as it was before this change.

Suggested change
matrix: *matrix
matrix:
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
spc-variant: linux-aarch64
- runs-on: ubuntu-24.04
variant: linux_amd64
spc-variant: linux-x86_64
- runs-on: macos-15
variant: darwin_arm64
spc-variant: macos-aarch64
- runs-on: macos-15-intel
variant: darwin_amd64
spc-variant: macos-x86_64

Copilot uses AI. Check for mistakes.
runs-on: ${{ matrix.runs-on }}
env:
GOFLAGS: '-mod=mod'
Expand Down
Loading