build(desktop): code-sign + notarize the macOS build - #57
Merged
Conversation
Replace identity:null with a signed, hardened-runtime, notarized macOS build. Adds entitlements (allow-jit, allow-unsigned-executable-memory, disable-library-validation, allow-dyld-environment-variables) required so the forked Node server, node-pty spawn-helper, and ELECTRON_RUN_AS_NODE keep working under hardened runtime. Workflow feeds CSC_* / APPLE_* secrets on the macOS job; Windows/Linux remain unsigned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Load CSC_*/APPLE_* from 1Password via load-secrets-action on the macOS job instead of GitHub secrets; only OP_SERVICE_ACCOUNT_TOKEN stays a repo secret. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace identity:null with a signed, hardened-runtime, notarized macOS build.
Adds entitlements (allow-jit, allow-unsigned-executable-memory,
disable-library-validation, allow-dyld-environment-variables) required so the
forked Node server, node-pty spawn-helper, and ELECTRON_RUN_AS_NODE keep
working under hardened runtime. Workflow feeds CSC_* / APPLE_* secrets on the
macOS job; Windows/Linux remain unsigned.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com