Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DATABASE_URL) and add a central job runtime service atsrc/server/services/jobService.ts.src/server/jobs:definitions/cleanup-orphaned-images.job.tsdefinitions/scheduled-test.job.tsregistry.tstypes.tsjobServicein DI (src/server/api/di-container.ts) and bootstrap it at server startup.src/test/mocks/mock-job-service.tsand wire it intosrc/test/test-container.ts.Key Design Changes
KnownJobName)JobPayload<TJobName>)run(jobName, data?, options?):runAt/startAfter)cron, optionalstartAt,endAt,tz)startupstartup.cronpresent => recurring startup schedulestartup.cronabsent => one-off startup enqueuerun(..., { cron, correlationId })creates correlation-specific recurring streamsunschedule(jobName, { correlationId })cancels only that streamunschedule(jobName)remains supported to cancel all schedules for a jobTest Plan
jobServiceboots without errors.jobs.cleanup-orphaned-images.jobs.scheduled-test.run()for:runAt)cron)unschedule(jobName, { correlationId })and verify only targeted recurring stream is removed.unschedule(jobName)and verify all recurring schedules for that job are removed.MockJobService.