Cover a case in h3NeighborRotations when starting within the deleted k subsequence#1193
Merged
isaacbrodsky merged 2 commits intoJul 24, 2026
Conversation
when the starting cell is already within the deleted k subsequence.
|
coverage: 99.213% (+0.04%) from 99.176% — isaacbrodsky:h3-neighbor-rotations-failed-coverage into uber:master |
dfellis
approved these changes
Jul 22, 2026
justinhwang
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Claude to find an example case that triggers this E_FAILED return. The
oldLeadingDigitis 1 in this case, which represents an invalid index, so it is fine to fail here.