feat(queue/sql): add factory, tests, and documentation#24
Merged
Conversation
This was referenced Feb 17, 2026
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
b29f000 to
8d4d338
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
b2d2aa0 to
0e41ffa
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
8d4d338 to
7ef5cb2
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
2 times, most recently
from
a15f2b1 to
e0d857c
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
2 times, most recently
from
07c58fe to
9de4a23
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
e0d857c to
0794b57
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
9de4a23 to
8c32db0
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
2 times, most recently
from
e6dd227 to
d42e9fb
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
2 times, most recently
from
010ac2e to
d0f0ae6
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
d42e9fb to
b607469
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
d0f0ae6 to
37a2f33
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
b607469 to
783911f
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
37a2f33 to
4a17f4e
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
783911f to
fec5cdf
Compare
sbalabanov
approved these changes
Feb 20, 2026
| }() | ||
|
|
||
| // Wait for server to be ready | ||
| time.Sleep(100 * time.Millisecond) |
|
|
||
| // Start server in background | ||
| go func() { | ||
| s.Start() |
Contributor
There was a problem hiding this comment.
goroutine needs collection
|
|
||
| if f.subscriber != nil { | ||
| if err := f.subscriber.Close(); err != nil { | ||
| errs = append(errs, err) |
Contributor
There was a problem hiding this comment.
can do errors.Join or fmt.Errorf("%w %w")
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
4a17f4e to
dc9f4cc
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
2 times, most recently
from
aca4bfe to
fcccb0c
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
fec5cdf to
69b12cb
Compare
behinddwalls
force-pushed
the
sql-queue-subscriber
branch
from
fcccb0c to
9ea80b3
Compare
behinddwalls
changed the base branch from
sql-queue-subscriber
to
sql-queue-stores
behinddwalls
changed the title
sbalabanov
approved these changes
Feb 20, 2026
behinddwalls
added a commit
that referenced
this pull request
Feb 20, 2026
## Summary ### Why? Need Publisher implementation to enable message publishing to SQL queue topics. ### What? - Publisher validates topic names and publishes single messages via MessageStore - Thread-safe with RWMutex for concurrent publish calls - Idempotent Close() operation - Comprehensive test coverage for publish, validation, metrics, and concurrency - Single and multiple message publishing tested - Invalid topic names rejected (uppercase, special chars, empty) - Publisher closed state prevents further publishes - Concurrent publish operations verified thread-safe - Context cancellation handled correctly ## Test Plan make test ## Issues ## Stack 1. @ #22 1. #23 1. #21 1. #24 1. #34
behinddwalls
force-pushed
the
sql-queue-stores
branch
from
05783ae to
5d6dd4a
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
69b12cb to
b0ebc92
Compare
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
b0ebc92 to
ff9f23e
Compare
Add Factory implementation (sql.go) for SQL queue that provides Publisher and Subscriber instances with proper lifecycle management.
behinddwalls
force-pushed
the
sql-queue-integration
branch
from
ff9f23e to
0e6c4cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Need to integrate publisher and subscriber with Queue factory interface and provide comprehensive documentation and end-to-end testing.
What?
Test Plan
Issues
Stack