docs(queue/sql): add comprehensive RFC for SQL queue design#25
Merged
Conversation
This was referenced Feb 17, 2026
1a3ef19 to
e7663ff
Compare
7f9dd0c to
3506dc0
Compare
2fe0918 to
5c2e4c5
Compare
3506dc0 to
5b4bd68
Compare
5c2e4c5 to
f06ea48
Compare
5b4bd68 to
9b3e117
Compare
f06ea48 to
068672d
Compare
9b3e117 to
826f9f0
Compare
sbalabanov
approved these changes
Feb 19, 2026
|
|
||
| ### Dead Letter Queue Table | ||
|
|
||
| ```sql |
Contributor
There was a problem hiding this comment.
I'd recommend (to AI) to avoid fully reflecting all the code in the doc
Contributor
There was a problem hiding this comment.
does not seem to belong to this review.... commit merged from another branch?
## Why? Document the design decisions, alternatives, and rationale behind the SQL queue implementation. ## What? - RFC covering requirements, alternatives (including Watermill), and trade-offs - Explanation of partition leasing and visibility timeout mechanisms - Performance characteristics and observability - Concise format referencing schema files instead of full SQL definitions ## Addressing PR Comments - Reduced verbosity: replaced full CREATE TABLE statements with key field summaries - Added references to actual schema files in extensions/queue/sql/schema/ - Simplified Watermill comparison to focus on key architectural differences - Kept essential information while reducing code blocks by ~60% ## Test Plan - RFC reviewed for technical accuracy - All described mechanisms match implementation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
826f9f0 to
65dc9d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Document the design decisions, alternatives, and rationale behind the SQL queue implementation for future reference and onboarding.
What?
Test Plan