Skip to content

docs(queue/sql): add comprehensive RFC for SQL queue design#25

Merged
behinddwalls merged 1 commit into
mainfrom
sql-queue-rfc
Feb 20, 2026
Merged

docs(queue/sql): add comprehensive RFC for SQL queue design#25
behinddwalls merged 1 commit into
mainfrom
sql-queue-rfc

Conversation

@behinddwalls
Copy link
Copy Markdown
Collaborator

@behinddwalls behinddwalls commented Feb 17, 2026

Summary

Why?

Document the design decisions, alternatives, and rationale behind the SQL queue implementation for future reference and onboarding.

What?

  • Comprehensive RFC covering requirements, alternatives, and trade-offs
  • Detailed explanation of partition leasing and visibility timeout mechanisms
  • Performance characteristics and scalability considerations
  • Migration plan and future work roadmap
  • Example queries and configuration reference

Test Plan

  • RFC reviewed for technical accuracy
  • All described mechanisms match implementation
  • Examples verified against actual code

@behinddwalls behinddwalls requested review from a team and sbalabanov as code owners February 17, 2026 06:32
@behinddwalls behinddwalls changed the base branch from sql-queue-integration to queue-interface February 17, 2026 07:28
@behinddwalls behinddwalls force-pushed the sql-queue-rfc branch 2 times, most recently from 7f9dd0c to 3506dc0 Compare February 17, 2026 07:55
Base automatically changed from queue-interface to main February 19, 2026 03:59
Comment thread docs/designs/sql-queue-rfc.md Outdated

### Dead Letter Queue Table

```sql
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend (to AI) to avoid fully reflecting all the code in the doc

Comment thread entities/queue/message.go
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem to belong to this review.... commit merged from another branch?

## Why?
Document the design decisions, alternatives, and rationale behind the SQL queue implementation.

## What?
- RFC covering requirements, alternatives (including Watermill), and trade-offs
- Explanation of partition leasing and visibility timeout mechanisms
- Performance characteristics and observability
- Concise format referencing schema files instead of full SQL definitions

## Addressing PR Comments
- Reduced verbosity: replaced full CREATE TABLE statements with key field summaries
- Added references to actual schema files in extensions/queue/sql/schema/
- Simplified Watermill comparison to focus on key architectural differences
- Kept essential information while reducing code blocks by ~60%

## Test Plan
- RFC reviewed for technical accuracy
- All described mechanisms match implementation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@behinddwalls behinddwalls merged commit b43bc7d into main Feb 20, 2026
1 check passed
@behinddwalls behinddwalls deleted the sql-queue-rfc branch February 20, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants