feat(stovepipe): derive build strategy in process step - #358
Merged
Conversation
Pin each admitted request to the queue's last-green baseline, falling back safely to full builds when ancestry is unavailable.
mnoah1
marked this pull request as ready for review
July 14, 2026 17:33
Reuse source-control resolution across queue CAS retries, record strategy outcomes, and keep the chosen strategy when a request CAS reloads an accepted row.
mnoah1
force-pushed
the
mnoah1/stovepipe-process-build-strategy
branch
from
July 14, 2026 18:27
14bfb30 to
17bbcb8
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-build-strategy
branch
from
July 14, 2026 19:54
4a8c221 to
9457616
Compare
behinddwalls
left a comment
Collaborator
There was a problem hiding this comment.
A few non-blocking nits from review — the core derive→claim→persist ordering looks right (strategy is derived against the same queue-row version the claim CAS validates, so the persisted baseline can't be stale), and threading strategy/baseURI through markProcessing also fixes the latent reload-clobber on main. Nits inline.
behinddwalls
approved these changes
Jul 14, 2026
Distinguish source-control resolution from ancestry failures and pin retry behavior when queue or request rows reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
Implementing proposed strategy selection from https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md
Test Plan
Incremental:
New Request:
Not an Ancestor