refactor(stovepipe): retire entity JSON queue serializers (CODEM-306) - #515
Merged
mnoah1 merged 1 commit intoAug 5, 2026
Conversation
Remove unused ToBytes/FromBytes helpers from Request and Build entities now that all stovepipe queue payloads use proto contracts in stovepipe/core/messagequeue.
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 5, 2026 15:27
mnoah1
enabled auto-merge
August 5, 2026 15:30
behinddwalls
approved these changes
Aug 5, 2026
behinddwalls
deleted the
mnoah1/codem-306-stovepipe-keep-queue-contracts-proto-only-retire-entity-json
branch
August 5, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToBytes/FromByteshelpers fromstovepipe/entity/request.goandstovepipe/entity/build.go, including the deadRequestIDwrapper typeBuildIDdocs to describe its BuildRunner role only (no queue serialization)stovepipe/core/messagequeueproto contract testsCloses #357
All stovepipe queue topics already use proto contracts (
ProcessRequest,BuildRequest,BuildSignal,Record); this removes the misleading entity JSON helpers that could steer new stages toward the wrong pattern.Test plan
bazel test //stovepipe/entity/... //stovepipe/core/messagequeue/...